Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combine events to eliminate redundant kevent(2) calls #638

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Combine events to eliminate redundant kevent(2) calls #638

merged 2 commits into from
Jun 17, 2024

Conversation

panjf2000
Copy link
Contributor

Updates #449

@panjf2000 panjf2000 changed the title Combine events to eliminate redundant kevent(2) call Combine events to eliminate redundant kevent(2) calls Jun 12, 2024
@panjf2000
Fix the clang-format issues
3cb3dac 
---------

Signed-off-by: Andy Pan <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.21%. Comparing base (4bb7cc4) to head (3cb3dac).
Report is 13 commits behind head on unstable.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable     #638      +/-   ##
============================================
- Coverage     70.24%   70.21%   -0.03%     
============================================
  Files           110      110              
  Lines         60039    60039              
============================================
- Hits          42174    42156      -18     
- Misses        17865    17883      +18

see 11 files with indirect coverage changes

@madolson
Copy link
Member

Since we don't hit this code by default: https://github.com/valkey-io/valkey/actions/workflows/daily.yml

@madolson
Copy link
Member

Meant to link this one: https://github.com/valkey-io/valkey/actions/runs/9523145600/job/26254023104

madolson
madolson approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@madolson madolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@madolson madolson added release-notes This issue should get a line item in the release notes and removed release-notes This issue should get a line item in the release notes labels Jun 17, 2024
@madolson madolson merged commit 5a51bf5 into valkey-io:unstable Jun 17, 2024
18 checks passed
@madolson madolson added the release-notes This issue should get a line item in the release notes label Jun 17, 2024
@panjf2000 panjf2000 deleted the kevent-opt branch June 17, 2024 08:09
@wkgcass wkgcass mentioned this pull request Jun 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madolson madolson madolson approved these changes

Assignees
No one assigned
Labels
release-notes This issue should get a line item in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panjf2000 @madolson