-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust the log level of some logs in the cluster #633
Adjust the log level of some logs in the cluster #633
Conversation
I think the log of pfail status changes will be very useful. The other parts were scanned and found that it can be modified. Signed-off-by: Binbin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #633 +/- ##
============================================
- Coverage 70.19% 70.18% -0.01%
============================================
Files 110 110
Lines 60049 60077 +28
============================================
+ Hits 42149 42168 +19
- Misses 17900 17909 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @enjoy-binbin! I like these changes. My only question is around when to use NOTICE and when to use WARNING. I would like to see some discussion/clarification on them.
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
i don't have one, maybe madolson has more insight. |
The previous Redis decision was that LL_WARNING should be for system failures that operators should be notified about and can take action on but shouldn't halt the system (like a serverPanic). LL_NOTICE should be notifications that the average user might want to know about when looking back at the log to understand why something happened (replication disconnects, failovers, elections, etc). |
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]> Co-authored-by: Madelyn Olson <[email protected]>
Signed-off-by: Binbin <[email protected]>
I think the log of pfail status changes will be very useful.
The other parts were scanned and found that it can be modified.
Changes: