Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the log level of some logs in the cluster #633

Merged
merged 6 commits into from
Jun 18, 2024

Conversation

enjoy-binbin
Copy link
Member

@enjoy-binbin enjoy-binbin commented Jun 12, 2024

I think the log of pfail status changes will be very useful.
The other parts were scanned and found that it can be modified.

Changes:

  1. Changing pfail status releated logs from VERBOSE to NOTICE.
  2. Changing configEpoch collision log from VERBOSE(warning) to NOTICE.
  3. Changing some logs from DEBUG to NOTICE.

I think the log of pfail status changes will be very useful.
The other parts were scanned and found that it can be modified.

Signed-off-by: Binbin <[email protected]>
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (5d9d418) to head (b045e78).
Report is 7 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable     #633      +/-   ##
============================================
- Coverage     70.19%   70.18%   -0.01%     
============================================
  Files           110      110              
  Lines         60049    60077      +28     
============================================
+ Hits          42149    42168      +19     
- Misses        17900    17909       +9     
Files Coverage Δ
src/cluster_legacy.c 85.92% <100.00%> (+0.30%) ⬆️

... and 20 files with indirect coverage changes

Copy link
Member

@PingXie PingXie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @enjoy-binbin! I like these changes. My only question is around when to use NOTICE and when to use WARNING. I would like to see some discussion/clarification on them.

src/cluster_legacy.c Outdated Show resolved Hide resolved
@enjoy-binbin
Copy link
Member Author

My only question is around when to use NOTICE and when to use WARNING. I would like to see some discussion/clarification on them.

i don't have one, maybe madolson has more insight.
currently I am based on experience

src/cluster_legacy.c Outdated Show resolved Hide resolved
@madolson
Copy link
Member

madolson commented Jun 14, 2024

i don't have one, maybe madolson has more insight. currently I am based on experience

The previous Redis decision was that LL_WARNING should be for system failures that operators should be notified about and can take action on but shouldn't halt the system (like a serverPanic). LL_NOTICE should be notifications that the average user might want to know about when looking back at the log to understand why something happened (replication disconnects, failovers, elections, etc).

src/cluster_legacy.c Outdated Show resolved Hide resolved
Signed-off-by: Binbin <[email protected]>
src/cluster_legacy.c Outdated Show resolved Hide resolved
enjoy-binbin and others added 2 commits June 17, 2024 11:50
Signed-off-by: Binbin <[email protected]>

Co-authored-by: Madelyn Olson <[email protected]>
Signed-off-by: Binbin <[email protected]>
@enjoy-binbin enjoy-binbin merged commit 495a121 into valkey-io:unstable Jun 18, 2024
19 checks passed
@enjoy-binbin enjoy-binbin deleted the adjust_loglevel branch June 18, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants