-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add filter for test directory in runtest util #630
base: unstable
Are you sure you want to change the base?
Conversation
Signed-off-by: Harkrishn Patro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #630 +/- ##
============================================
+ Coverage 70.11% 70.26% +0.14%
============================================
Files 110 110
Lines 60038 60039 +1
============================================
+ Hits 42096 42184 +88
+ Misses 17942 17855 -87 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
What I've really been missing though is the possibility to find test suites using tab completion.
What if we add an option that takes a file name as its arguments? I mean a path relative to the working directory, so that tab completion actually works. If a directory is provided, it can run all tests in that directory. WDYT?
Good suggestion. Let me try out. |
Signed-off-by: Harkrishn Patro <[email protected]>
@zuiderkwast PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it can work, with these limitations:
- It accepts paths relative the repo root dir only. It doesn't accept absolute paths or relative somewhere else, if the current directory is changed.
- It can't be repeated, like
--single
can.
How about we make --single
and --skipunit
and others work with filenames and dirs in addition to the current format? We could expand all unit names to absolut names and work with that internally. I think we can trust filenames from the user without filtering them.
I like this idea. |
Helps testing specific functionality like
cluster
rather than running the entire test suite.Usage example