Deflake total sum of full synchronizations #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deflake test "PSYNC2: total sum of full synchronizations at least 4" Explaination: during the prior test "PSYNC2: generate load while killing replication links" load is generated on the master, and the replica's connection is killed multiple times. On busy machine this load can force the replica to full sync. There is no guarantee that the replicas will find the necessary bytes in the COB. Signed-off-by: naglera <[email protected]>
zuiderkwast
approved these changes
Aug 31, 2024
|
Have you seen this fail recently in Daily? If yes, then this fix is good to include in 8.0. |
|
I haven't seen this test fail in a long, long time. (It was hardened a long time ago by me and oran) |
|
I don't recall if I saw this specific test failing locally or in a PR GitHub workflow. However, the scenario where the primary does not have the necessary replication data for PSYNC is a valid possibility, especially under high load conditions and when the connection between the master and replica is often killed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stabilize test
PSYNC2: total sum of full synchronizations at least 4Explanation: During the previous test
PSYNC2: generate load while killing replication links, load is generated on the master, and the replica's connection is repeatedly terminated. On a busy machine, this load can cause the replica to perform a full sync. There is no guarantee that the replicas will find the necessary bytes in the COB.