module: fix typo in REGISTER_API
#608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`REGISTER_API` is supposed to register two functions: one starts with `ValkeyModule_` and the other one with `RedisModule_`. It does so in `unstable` branch. However there was a copy-paste mistake during backporting it to 7.2. This caused modules built with `valkeymodule-rs` to fail since they called `RedisModule_SetModuleAttribs` which caused valkey to segfault. This commit fixes the typo. Signed-off-by: Mikhail Koviazin <[email protected]>
madolson
added
the
release-notes
madolson
approved these changes
Jun 7, 2024
enjoy-binbin
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REGISTER_APIis supposed to register two functions: one starts withValkeyModule_and the other one withRedisModule_. It does so inunstablebranch. However there was a copy-paste mistake during backporting it to 7.2. This caused modules built withvalkeymodule-rsto fail since they calledRedisModule_SetModuleAttribswhich caused valkey to segfault.This commit fixes the typo.