-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Total" message and used_memory_human log information in serverCron() function #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ron() function Signed-off-by: NAM UK KIM <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #594 +/- ##
=========================================
Coverage 70.58% 70.59%
=========================================
Files 112 112
Lines 61528 61531 +3
=========================================
+ Hits 43431 43436 +5
+ Misses 18097 18095 -2
|
…ron() function Signed-off-by: NAM UK KIM <[email protected]>
…ron() function Signed-off-by: NAM UK KIM <[email protected]>
madolson
reviewed
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, seems reasonable to me to improve the debug log line.
Signed-off-by: NAM UK KIM <[email protected]>
zvi-code
reviewed
Jul 3, 2024
Signed-off-by: NAM UK KIM <[email protected]>
@madolson please also take a look. |
madolson
reviewed
Aug 23, 2024
Signed-off-by: Madelyn Olson <[email protected]>
madolson
approved these changes
Aug 23, 2024
Signed-off-by: Madelyn Olson <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 2, 2024
…rCron() function (#594) At the VERBOSE/DEBUG log level, which is output once every 5 seconds, added to show the "Total" message of all clients and to show memory usage (used_memory) with used_memory_human. Also, it seems clearer to show "total" number of keys and the number of volatile in entire keys. --------- Signed-off-by: NAM UK KIM <[email protected]>
madolson
pushed a commit
that referenced
this pull request
Sep 3, 2024
…rCron() function (#594) At the VERBOSE/DEBUG log level, which is output once every 5 seconds, added to show the "Total" message of all clients and to show memory usage (used_memory) with used_memory_human. Also, it seems clearer to show "total" number of keys and the number of volatile in entire keys. --------- Signed-off-by: NAM UK KIM <[email protected]>
lilpoozie2005
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the VERBOSE/DEBUG log level, which is output once every 5 seconds, added to show the "Total" message of all clients and to show memory usage (used_memory) with used_memory_human.
Also, it seems clearer to show "total" number of keys and the number of volatile in entire keys.
Closes #643