update server.call in the place of redis.call in test directory. #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madolson
reviewed
May 6, 2024
| foreach script_compatibility_api {server redis} { | ||
| foreach script_compatibility_api {server valkey} { |
There was a problem hiding this comment.
If we want to remove all the references of redis in this file. We can update the compatibility code below to do a find replace of server -> redis, and then update all the code in this file to also use server.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #444 +/- ##
============================================
- Coverage 70.54% 70.12% -0.42%
============================================
Files 114 114
Lines 61644 61644
============================================
- Hits 43488 43230 -258
- Misses 18156 18414 +258 |
Shivshankar-Reddy
changed the title
|
@Shivshankar-Reddy Are you going to update this |
|
Hi @madolson yes, I will update soon.. |
Shivshankar-Reddy
force-pushed
the
redis-call-to-valkey
branch
from
892bbab to
ab8da42
Compare
Signed-off-by: Shivshankar-Reddy <[email protected]>
Signed-off-by: Shivshankar-Reddy <[email protected]>
hwware
force-pushed
the
redis-call-to-valkey
branch
from
ab8da42 to
b39730d
Compare
| @@ -361,7 +361,7 @@ start_server {overrides {save ""}} { | |||
|
|
|||
| exec cp -f tests/assets/scriptbackup.rdb $server_path | |||
| start_server [list overrides [list "dir" $server_path "dbfilename" "scriptbackup.rdb" "appendonly" "no"]] { | |||
| # the script is: "return redis.call('set', 'foo', 'bar')"" | |||
| # the script is: "return server.call('set', 'foo', 'bar')"" | |||
| # its sha1 is: a0c38691e9fffe4563723c32ba77a34398e090e6 | |||
There was a problem hiding this comment.
i think we need to also update the sha?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated all the files apart from scripting.tcl as it has both server and redis. Will update the file later.