Only (re-)send MEET packet once every handshake timeout period #1441
+42
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add meet_sent field in clusterNode indicating the last time we sent a MEET packet. Use this field to only (re-)send a MEET packet once every handshake timeout period. Improve some logging messages to include human_nodename. Add nodeExceedsHandshakeTimeout() function. Signed-off-by: Pierre Turin <[email protected]>
pieturin
force-pushed
the
cluster-handshake-fix-followup
branch
from
de51f6d to
64903fe
Compare
Signed-off-by: Pierre Turin <[email protected]>
pieturin
force-pushed
the
cluster-handshake-fix-followup
branch
from
629bfaa to
e9b1b3c
Compare
|
@enjoy-binbin, @PingXie, please take a look at this PR when you have the chance. |
enjoy-binbin
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
meet_sentfield inclusterNodeindicating the last time we sent a MEET packet. Use this field to only (re-)send a MEET packet once every handshake timeout period when detecting a node without an inbound link.Improve some logging messages to include
human_nodename. AddnodeExceedsHandshakeTimeout()function.This is a follow-up to this previous PR: #1307
And a partial fix to the crash described in: #1436