Extract the scripting engine code from the functions unit #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the module API to support the addition of different scripting engines to run user defined functions. The scripting engine can be implemented as a Valkey module, and can be dynamically loaded with the `loadmodule` config directive, or with the `MODULE LOAD` command. The current module API support, only allows to load scripting engines to run functions using `FCALL` command. In a follow up PR, we will move the Lua scripting engine implmentation into its own module. Signed-off-by: Ricardo Dias <[email protected]>
This commit adds a module with a very simple stack based scripting language implementation to test the new module API that allows to implement new scripting engines as modules. Signed-off-by: Ricardo Dias <[email protected]>
Signed-off-by: Ricardo Dias <[email protected]>
Signed-off-by: Ricardo Dias <[email protected]>
Signed-off-by: Ricardo Dias <[email protected]>
…ORE|DELETE] Signed-off-by: Ricardo Dias <[email protected]>
rjd15372
force-pushed
the
refactor-engine-1261
branch
from
40bcded
to
e8db485
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## unstable #1312 +/- ##
============================================
+ Coverage 70.63% 70.73% +0.10%
============================================
Files 116 118 +2
Lines 63303 63493 +190
============================================
+ Hits 44711 44910 +199
+ Misses 18592 18583 -9
|
|
@rjd15372 You could point the merge branch as your initial branch. It will show only the diff then. |
…ions.c` Signed-off-by: Ricardo Dias <[email protected]>
rjd15372
force-pushed
the
refactor-engine-1261
branch
2 times, most recently
from
0cad7ff
to
6af7c63
Compare
… functionLibInfo in most places Signed-off-by: Ricardo Dias <[email protected]>
- Removed the `ValkeyModuleScriptingEngineFunctionLibrary` structure. - Changed a few structure and parameters names. Signed-off-by: Ricardo Dias <[email protected]>
Signed-off-by: Ricardo Dias <[email protected]>
Signed-off-by: Ricardo Dias <[email protected]>
rjd15372
force-pushed
the
refactor-engine-1261
branch
2 times, most recently
from
2db2efb
to
990447a
Compare
This commit creates a new unit for the scripting engine code by extracting the existing code from the functions unit. We're doing this refactor to prepare the code for runnning the `EVAL` command using different scripting engines. Signed-off-by: Ricardo Dias <[email protected]>
rjd15372
force-pushed
the
refactor-engine-1261
branch
from
990447a
to
54eb99f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: this PR is on top of #1277, please ignore the common commits. I'll keep this PR in draft mode until #1277 is merged
This commit creates a new unit for the scripting engine code by extracting the existing code from the functions unit.
We're doing this refactor to prepare the code for runnning the
EVALcommand using different scripting engines.Signed-off-by: Ricardo Dias [email protected]