fix: readonly client moved inconsistency #1284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: proost <[email protected]>
…ix-inconsistency-moved-readonly-client Signed-off-by: proost <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1284 +/- ##
============================================
+ Coverage 70.57% 70.62% +0.04%
============================================
Files 117 117
Lines 63320 63333 +13
============================================
+ Hits 44690 44730 +40
+ Misses 18630 18603 -27
|
hpatro
reviewed
Nov 26, 2024
Comment on lines
+393
to
+399
| if (n == NULL || !clusterNodeIsMyself(n)) { | ||
| if (error_code == CLUSTER_REDIR_MOVED || error_code == CLUSTER_REDIR_ASK) { | ||
| int port = clusterNodeClientPort(n, connIsTLS(original_c->conn)); | ||
| *err = sdscatprintf(sdsempty(), "-%s %d %s:%d", (error_code == CLUSTER_REDIR_ASK) ? "ASK" : "MOVED", | ||
| hashslot, clusterNodePreferredEndpoint(n, c), port); | ||
| return C_ERR; | ||
| } |
There was a problem hiding this comment.
Could we use clusterRedirectClient method instead of handling the error manually?
There was a problem hiding this comment.
unforunately, we can't because after returned scriptVerifyWriteCommandAllow we should go to "error" label.
in the error label, handling reply.
…ix-readonly-client-moved-inconsistency Signed-off-by: proost <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #869
When client is read-only and client send lua script with write command to replica, return redirect response