represent cluster node flags with bitwise shift value (#642)

While debugging a cluster bus issue, found the cluster node flags were represented in numbers. I generally find it easy when these are represented as bitwise shift operation. It improves readability a bit. Signed-off-by: Harkrishn Patro <[email protected]>
valkey-io · Jun 13, 2024 · 76fc041 · 76fc041
1 parent d211078
commit 76fc041
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/src/cluster_legacy.h b/src/cluster_legacy.h
@@ -41,17 +41,17 @@ typedef struct clusterLink {
 } clusterLink;
 
 /* Cluster node flags and macros. */
-#define CLUSTER_NODE_PRIMARY 1                 /* The node is a primary */
-#define CLUSTER_NODE_REPLICA 2                 /* The node is a replica */
-#define CLUSTER_NODE_PFAIL 4                   /* Failure? Need acknowledge */
-#define CLUSTER_NODE_FAIL 8                    /* The node is believed to be malfunctioning */
-#define CLUSTER_NODE_MYSELF 16                 /* This node is myself */
-#define CLUSTER_NODE_HANDSHAKE 32              /* We have still to exchange the first ping */
-#define CLUSTER_NODE_NOADDR 64                 /* We don't know the address of this node */
-#define CLUSTER_NODE_MEET 128                  /* Send a MEET message to this node */
-#define CLUSTER_NODE_MIGRATE_TO 256            /* Primary eligible for replica migration. */
-#define CLUSTER_NODE_NOFAILOVER 512            /* replica will not try to failover. */
-#define CLUSTER_NODE_EXTENSIONS_SUPPORTED 1024 /* This node supports extensions. */
+#define CLUSTER_NODE_PRIMARY (1 << 0)               /* The node is a primary */
+#define CLUSTER_NODE_REPLICA (1 << 1)               /* The node is a replica */
+#define CLUSTER_NODE_PFAIL (1 << 2)                 /* Failure? Need acknowledge */
+#define CLUSTER_NODE_FAIL (1 << 3)                  /* The node is believed to be malfunctioning */
+#define CLUSTER_NODE_MYSELF (1 << 4)                /* This node is myself */
+#define CLUSTER_NODE_HANDSHAKE (1 << 5)             /* We have still to exchange the first ping */
+#define CLUSTER_NODE_NOADDR (1 << 6)                /* We don't know the address of this node */
+#define CLUSTER_NODE_MEET (1 << 7)                  /* Send a MEET message to this node */
+#define CLUSTER_NODE_MIGRATE_TO (1 << 8)            /* Primary eligible for replica migration. */
+#define CLUSTER_NODE_NOFAILOVER (1 << 9)            /* replica will not try to failover. */
+#define CLUSTER_NODE_EXTENSIONS_SUPPORTED (1 << 10) /* This node supports extensions. */
 #define CLUSTER_NODE_NULL_NAME                                                                                         \
     "\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000\000" \
     "\000\000\000\000\000\000\000\000\000\000\000\000"