-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Load a folder of views #24
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Now the readme is updated but require a review from @valberg |
Hi @Mte90 Thanks for the pull request. I'm not sure that this is the right approach. I would much rather that we traverse the contents of a python module than directly interacting with the filesystem. I think that could be accomplished by using Also I think we should be explicit about how the functionality is used. One should be explicit about wanting to scan all modules in a package, so we should introduce a new keyword argument "extra_packages" to solve this case. Basically I want the API to be:
|
|
||
* `paths`: is in a plural form because support also a list of paths | ||
* `name` the classic route name | ||
* `namespace`: {I don't know what to write here} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is required a review here
So I added the new parameter and updated the readme but about To me is better if we don't know need to to define a variable with the root folder so it should be more fast butI don't know how to achieve it, I am not so much experience in this python knowledge. |
ping @valberg |
This fix #13
In urls.py it is required that code:
In this way loads from a folder the various views automatically.
I will update the readme tomorrow (also some parameters like login_required are not documented, I will do that).