Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some more short variable names to allowed by swiftlint. Removed 'weak' from protocol #63

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added some more short variable names to allowed by swiftlint. Removed 'weak' from protocol #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
214f1ab
Added some more short variable names to allowed by swiftlint: they ar…
dtmpamk Oct 18, 2018
51bd860
travis xcode version bump
dtmpamk Oct 18, 2018
04e4a5d
github access token added
dtmpamk Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .swiftlint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,9 @@ variable_name:
excluded: # excluded via string array
- x
- y
- i
- j
- d
- v
- a
reporter: "xcode" # reporter type (xcode, json, csv, checkstyle)
11 changes: 6 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,16 @@
osx_image: xcode9
osx_image: xcode10
language: objective-c
xcode_sdk: iphonesimulator10.0

before_install:
- brew update
- if brew outdated | grep -qx carthage; then brew upgrade carthage; fi
- travis_wait 35 carthage bootstrap --platform iOS

script:
- set -o pipefail
- travis_retry xcodebuild -project Beethoven.xcodeproj -scheme "Beethoven-iOS" -destination "platform=iOS Simulator,name=iPhone 6" build-for-testing test | xcpretty

- travis_retry xcodebuild -project Beethoven.xcodeproj -scheme "Beethoven-iOS" -destination
"platform=iOS Simulator,name=iPhone 6" build-for-testing test | xcpretty
notifications:
email: false
env:
global:
secure: n8IzprXBZebE5sMmW5pltuk1Oo1StTd8kLaPuMf6Q633aAk/FKM8z0cDW6VWt8r5kFIFfdcpU86/kDaKofGb4E5was4O9gAGUKegzdDE+eHqyeDwMCKRkfEP6IP662kWSAW6iPyk63FAxkIN8QrlHbwge/kAiJ1Lze3lUfvw8jT5gucXDDdTgQ+2hc4y8t5EKHfJNYFv1RKB3TtXC5nkANyHdhXaxdYqO3yEK+rPDue/C2g/+LNdlR+wJNyyZ7L7igqQZkTChskX1y5fgYD1UElXDZvGsYXfRdaE9SprQhwkzHvCWfGOq3dbTgHWLNtYDXoy6nqe9EgD30NQZEPEGPHHv4jYHvE5njxJHu2MDXcySVJ36Niee+4Ox02OjbGZNOFE1Os1geS1lKVh8hAHqS5W3IBxQ8jui3EfQp4BpBqm9JdcuxrG/lIcGah3Ix0kRfiDXk4QT7oiypWjQX54Y0wCb0Ix0D+fR4q3Ndbrc/Eck9GYpIB6+eW1bFl+jaxWeoeTAHt/dCrTzilOgFfbw+1gBWFR76WCdoRlr3m3fAnxZvlRh42SdefMGN8XsBxmUg7lgHbP24I1FF3l6Zv2MQfiiz4dKFb6S0krR1loTgdB7foMWLdXMGk9AsgK+njCiqawALUhj9I/wJ2k1+bsD28xhJ0aRrgLbPWXmGcFBR8=
2 changes: 1 addition & 1 deletion Source/SignalTracking/SignalTracker.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public protocol SignalTracker: class {
var levelThreshold: Float? { get set }
var peakLevel: Float? { get }
var averageLevel: Float? { get }
weak var delegate: SignalTrackerDelegate? { get set }
var delegate: SignalTrackerDelegate? { get set }

func start() throws
func stop()
Expand Down