Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(solana): Add support for Token-2022 tokens #35

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(solana): Add support for Token-2022 tokens #35

wants to merge 1 commit into from
+324 −46

Conversation

MartinZemanik
Copy link
Collaborator

This PR adds support for Solana Token-2022 tokens. This means:

  • Users can view Token-2022 tokens in the tokens list
  • Users can send Token-2022 tokens
  • Suite correctly parses sent and received transactions for Token-2022 tokens and displays them in the tx history

Screenshots:

Tokens list

tokens-list

Send token

send

Transaction history

tx-history-received tx-history-sent

@MartinZemanik MartinZemanik self-assigned this Dec 2, 2024
PeterBenc
PeterBenc approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@PeterBenc PeterBenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just nitpicks, I tested sending and it works.

packages/blockchain-link-utils/src/solana.ts Outdated Show resolved Hide resolved
packages/blockchain-link-utils/src/solana.ts Outdated Show resolved Hide resolved
suite-common/wallet-utils/src/__fixtures__/solanaUtils.ts Outdated Show resolved Hide resolved
gabrielKerekes
gabrielKerekes approved these changes Dec 4, 2024
View reviewed changes
Copy link
Collaborator

@gabrielKerekes gabrielKerekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Just minor nit picks - feel free to decide not to include them 😄 I've just reviewed the code, I haven't run the app/tests.

packages/blockchain-link/src/workers/solana/index.ts Outdated Show resolved Hide resolved
packages/blockchain-link/src/workers/solana/index.ts Outdated Show resolved Hide resolved
packages/blockchain-link/src/workers/solana/index.ts Outdated Show resolved Hide resolved
packages/blockchain-link/src/workers/solana/index.ts Outdated Show resolved Hide resolved
packages/connect/src/api/blockchainEstimateFee.ts Outdated Show resolved Hide resolved
packages/connect/src/api/blockchainEstimateFee.ts Outdated Show resolved Hide resolved
suite-common/wallet-utils/src/solanaUtils.ts Outdated Show resolved Hide resolved
@MartinZemanik MartinZemanik force-pushed the solana-token-2022-support branch from 77d849d to f59f6d3 Compare December 4, 2024 12:59
@MartinZemanik MartinZemanik force-pushed the solana-token-2022-support branch from f59f6d3 to fa21595 Compare December 4, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterBenc PeterBenc PeterBenc approved these changes

@gabrielKerekes gabrielKerekes gabrielKerekes approved these changes

Assignees

@MartinZemanik MartinZemanik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinZemanik @gabrielKerekes @PeterBenc