fix(core): add display_name for missing token_mint #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common/defs/solana/programs.json
Outdated
| @@ -1692,6 +1692,10 @@ | |||
| { | |||
| "account": "owner", | |||
| "display_name": "Mint authority" | |||
| }, | |||
| { | |||
| "account": "token_mint", | |||
There was a problem hiding this comment.
Let's move this to the first place under ui_properties since the order also determines how the information gets displayed.
And then please change display_name of amount parameter to Burn amount.
gabrielKerekes
requested changes
Jan 14, 2025
There was a problem hiding this comment.
"Mint To" instruction should also display the token being minted 🙏
Please see comments (they apply for both Token and Token22 I think).
Also please create some solana-token-definitions-merge-branch into which we would merge these changes as well, so we'd only create one slightly larger PR for Trezor when everything's ready.
arjaz
force-pushed
the
solana-token-mint
branch
from
5423aa7 to
91eed7f
Compare
arjaz
changed the base branch from
solana-loadable-tokens
to
solana-token-definitions-merge-branch
arjaz
force-pushed
the
solana-token-definitions-merge-branch
branch
from
b98d58a to
3515cf3
Compare
arjaz
force-pushed
the
solana-token-mint
branch
from
91eed7f to
44bde8e
Compare
arjaz
force-pushed
the
solana-token-mint
branch
3 times, most recently
from
f04aa64 to
fa828f1
Compare
arjaz
force-pushed
the
solana-token-mint
branch
from
fa828f1 to
9995475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.