-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move workflows for Nim Devel and legacy i386 from "Daily" #968
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #968 +/- ##
============================================
+ Coverage 83.20% 83.23% +0.03%
============================================
Files 91 91
Lines 15308 15326 +18
============================================
+ Hits 12737 12757 +20
+ Misses 2571 2569 -2 |
|
@arnetheduck This PR will still keep running Daily for i386, just in specialized workflow for legacy platforms. If you could name at least one recent 32bit platform, which has some public adoption, we could definitely discuss to include it in main workflow and provide first grade support. You would probably agree we don't have unlimited resources to support all platforms equally. I would even add, being selective and timely on what we support to which extent could make or break usability of something so essential like p2p library. |
raspberry pi, android, openwrt (ie most home wifi routers out there) |
Let me discuss those internally within Status. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good, just added two small comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, address my question.
b49a68a
to
60f9536
Compare
- remove workflow for Nim Devel from Daily - rename workflow to Daily - Nim Devel - refactor workflows to reduce duplicities - ump outdated actions/checkout@v4, actions/setup-go@v4 - change deprecated option --gc -> --mm - split out legacy platforms (i386) - better WF names with emphasis on target, Nim Devel, Legacy Platforms - new line added
We have "unstable" as a default branch. Others may expect from it more stability than its name suggest. I propose to make "Daily" workflow more reliable by moving tests with Nim Devel to separate (experimental?) workflow.