-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add doc for typescript auth helpers #94
Conversation
✔️ Deploy preview for vaadin-docs-preview ready! 🔨 Explore the source changes: 5f75e38 🔍 Inspect the deploy logs: https://app.netlify.com/sites/vaadin-docs-preview/deploys/600887b1b134860008cf9f12 😎 Browse the preview: https://deploy-preview-94--vaadin-docs-preview.netlify.app |
@haijian-vaadin, please update from master, to get the Vale check running correctly. Do a rebase preferably, if possible. Otherwise you need to touch each .asciidoc file to trigger the check for them. |
articles/fusion/security/fusion-security-custom-spring-login.asciidoc
Outdated
Show resolved
Hide resolved
articles/fusion/security/fusion-security-custom-spring-login.asciidoc
Outdated
Show resolved
Hide resolved
articles/fusion/security/fusion-security-custom-spring-login.asciidoc
Outdated
Show resolved
Hide resolved
articles/fusion/security/fusion-security-custom-spring-login.asciidoc
Outdated
Show resolved
Hide resolved
articles/fusion/security/fusion-security-handle-session-expiration.asciidoc
Outdated
Show resolved
Hide resolved
articles/fusion/security/fusion-security-handle-session-expiration.asciidoc
Outdated
Show resolved
Hide resolved
articles/fusion/security/fusion-security-handle-session-expiration.asciidoc
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It pains me a little bit, that there are two login-view.ts
files that have some amount of the same code.
I wonder if there’s a way to avoid the duplication? I didn’t look in detail if that would make sense, though – maybe the examples are different enough that the copy-pasted code doesn’t hurt.
articles/fusion/security/fusion-security-handle-session-expiration.asciidoc
Outdated
Show resolved
Hide resolved
articles/fusion/security/fusion-security-handle-session-expiration.asciidoc
Outdated
Show resolved
Hide resolved
articles/fusion/security/fusion-security-handle-session-expiration.asciidoc
Outdated
Show resolved
Hide resolved
articles/fusion/security/fusion-security-handle-session-expiration.asciidoc
Outdated
Show resolved
Hide resolved
frontend/demo/fusion/authentication/handle-session-expiration/login-view.ts
Outdated
Show resolved
Hide resolved
Oh, finally it's all green, no more Vale errors. |
Got this TS error when running
|
I noticed an error in the build:
Seems to be because of the line just before:
What is this for, is it needed? |
Confirmed with the doc team, it's not needed, I removed it. |
There are some one sentence per line and similar Vale errors in that file ( |
38001ef
to
aebb39a
Compare
a24d36f
to
d856e20
Compare
.github/styles/Vocab/Docs/accept.txt
Outdated
@@ -29,6 +29,7 @@ repo | |||
[sS]crollbars? | |||
[sS]croller | |||
[sS]ervlets? | |||
src |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not introduce this change. Where is this causing problems? I believe all occurences of this “word” should either be inside code snippets or [filename]##
classes, and therefore not part of the linting checks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember, I think I got a Vale error. I can remove this and let's see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.github/styles/Vocab/Docs/accept.txt
Outdated
JWT | ||
Karaf | ||
LDAP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These (JWT and LDAP) should be added to Abbr.yml, not here, if we want to make these as exceptions of abbreviations that we don’t need to explain. But I’m hesitant in adding them, because I would not expect all readers to know what they mean.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the comment, done
This PR copies the commit done in the old doc repo for typescript authentication helpers.
For vaadin/flow-and-components-documentation#1402.