Skip to content

Commit

Permalink
Merge pull request #43 from v3io/development
Browse files Browse the repository at this point in the history
disable v3io aggregations by default + changea query log to info (#42)
  • Loading branch information
gtopper authored May 2, 2019
2 parents e25bd68 + 5803d0a commit af7ed0d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions cmd/prometheus/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,8 @@ func main() {
},
// V3io related updates
func(cfg *config.Config) error {
localStorage.SetUseV3ioAggregations(!cfg.DisableV3ioAggregations)
queryEngine.UseV3ioAggregations = !cfg.DisableV3ioAggregations
localStorage.SetUseV3ioAggregations(cfg.UseV3ioAggregations)
queryEngine.UseV3ioAggregations = cfg.UseV3ioAggregations

return nil
},
Expand Down
2 changes: 1 addition & 1 deletion config/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ type Config struct {
RemoteWriteConfigs []*RemoteWriteConfig `yaml:"remote_write,omitempty"`
RemoteReadConfigs []*RemoteReadConfig `yaml:"remote_read,omitempty"`

DisableV3ioAggregations bool `yaml:"disableV3ioAggregations,omitempty"`
UseV3ioAggregations bool `yaml:"useV3ioAggregations,omitempty"`

// original is the input from which the config was parsed.
original string
Expand Down
4 changes: 2 additions & 2 deletions promql/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -587,7 +587,7 @@ func (ng *Engine) populateSeries(ctx context.Context, q storage.Queryable, s *Ev
params.End = params.End - offsetMilliseconds
}

level.Debug(ng.logger).Log("msg", "Querying v3io vector selector",
level.Info(ng.logger).Log("msg", "Querying v3io vector selector",
"useV3ioAggregations", querier.(*tsdb.V3ioPromQuerier).UseAggregates,
"use3ioAggregationConfig", querier.(*tsdb.V3ioPromQuerier).UseAggregatesConfig)
set, wrn, err = querier.Select(params, n.LabelMatchers...)
Expand All @@ -610,7 +610,7 @@ func (ng *Engine) populateSeries(ctx context.Context, q storage.Queryable, s *Ev
params.End = params.End - offsetMilliseconds
}

level.Debug(ng.logger).Log("msg", "Querying v3io matrix selector",
level.Info(ng.logger).Log("msg", "Querying v3io matrix selector",
"useV3ioAggregations", querier.(*tsdb.V3ioPromQuerier).UseAggregates,
"use3ioAggregationConfig", querier.(*tsdb.V3ioPromQuerier).UseAggregatesConfig)
set, wrn, err = querier.Select(params, n.LabelMatchers...)
Expand Down

0 comments on commit af7ed0d

Please sign in to comment.