Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLRun] Reduce retention binlog to 1d #1033

Merged
merged 1 commit into from
Jul 25, 2024
+9 −2
Merged

[MLRun] Reduce retention binlog to 1d #1033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion stable/mlrun/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
name: mlrun
version: 0.9.26
version: 0.9.27
appVersion: 1.6.4
description: Machine Learning automation and tracking
sources:
Expand Down
3 changes: 2 additions & 1 deletion stable/mlrun/templates/db-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,13 @@ data:
INIT_SCRIPT="/etc/config/mysql/init-scripts/enable-root-remote-access.sql"

echo "Starting MySQL ..."

# TODO: review the innodb flags, they might not be needed anymore
mysqld \
--user={{- include "mlrun.db.DBRunUser" . }} \
--sql_mode="" \
--init-file=$INIT_SCRIPT \
--binlog-expire-logs-seconds={{- .Values.db.dbConfiguration.binlogExpireLogsSeconds }} \
--max-connections={{- .Values.db.dbConfiguration.maxConnections }} \
--innodb-adaptive-hash-index={{- .Values.db.dbConfiguration.innodb.adaptiveHashIndex }} \
--innodb-read-io-threads={{- .Values.db.dbConfiguration.innodb.readIOThreads }} \
Expand Down
6 changes: 6 additions & 0 deletions stable/mlrun/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,12 @@ db:
# SUPER is a MySQL privilege that grants admin rights to the user.
maxConnections: 512

# set to 1 day
# https://dev.mysql.com/doc/refman/8.4/en/replication-options-binary-log.html#sysvar_binlog_expire_logs_seconds
# binlogs are useful for replication, backup, and point-in-time recovery
# we dont use mysql replication, so we can set it to 1 day
binlogExpireLogsSeconds: 86400

innodb:
# refer to https://github.com/v3io/helm-charts/pull/674
adaptiveHashIndex: 0
Expand Down