Feature/2139 store invitations reset #485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabiede
requested changes
Jan 23, 2025
| @@ -123,6 +123,7 @@ module SurveyUrl = struct | |||
| let schema () = schema ~validation field () | |||
| end | |||
|
|
|||
| (* TODO: Remove this module *) | |||
| @@ -243,10 +243,26 @@ module DirectEnrollment : sig | |||
| val assignable : t -> bool | |||
| end | |||
|
|
|||
| module InvitationReset : sig | |||
| module Write : sig | |||
There was a problem hiding this comment.
why is there a "write" model, it's the same in both ways, isn't it?
| ~label:"add unique combination to pool_queue_jobs_mapping" | ||
| [%string | ||
| {sql| | ||
| CREATE TABLE pool_queue_job_%{table_suffix} ( |
There was a problem hiding this comment.
As discussed, add "_map" to name, otherwise might be confusing with "_history"
Suggested change
| CREATE TABLE pool_queue_job_%{table_suffix} ( | |
| CREATE TABLE pool_queue_job_map_%{table_suffix} ( |
Comment on lines
-113
to
+120
| let instance = Job.to_instance ~id ?message_template ?run_at label input job in | ||
| let clone_of = | ||
| match job_ctx with | ||
| | Create _ -> None | ||
| | Clone id -> Some id | ||
| in | ||
| let instance = | ||
| Job.to_instance ~id ?message_template ?run_at ?clone_of label input job | ||
| in |
There was a problem hiding this comment.
isn't there a simpler handling to achive this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.