-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(demo-game): add player's ready notification for admin #81
base: dev
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe pull request modifies the Changes
Possibly related PRs
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/demo-game/src/pages/admin/games/[id].tsx (1)
144-156
: Consider preventing repeated toasts.
TheuseEffect
runs wheneverdata?.game
changes. IfallPlayersReady
remains true through multiple re-renders, multiple toast notifications could appear. You might store a local flag or incorporate a memo/value check to ensure the toast displays only once for each game state transition.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/demo-game/src/pages/admin/games/[id].tsx
(4 hunks)
🔇 Additional comments (3)
apps/demo-game/src/pages/admin/games/[id].tsx (3)
30-30
: All good: Import statements are appropriate.
Bringing in useCallback
, useEffect
, and useState
is aligned with the hooks usage in this file.
62-62
: Import of useToast
is correctly added.
This import is essential for handling toast messages. No issues found.
126-127
: Toast usage introduced.
Destructuring the toast
function from useToast
is fine. Ensure the toast logic is only invoked when needed to avoid unnecessary re-renders or repeated messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
||
const allPlayersReady = game.players.every((player) => player.isReady) | ||
if (allPlayersReady) { | ||
toast({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have this make a sound?
Summary by CodeRabbit