Unsplit fix for new keys on both nodes #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found that after I start 2 nodes and split, I add new elements on node1 and new elements on node2 with differents keys, the usplit does not sync the new keys from both nodes, only one (depends on which node started to resolve the unsplit)
I replaced the original test, because it did not run, just waited forever on table creation, and extended with adding keys on both nodes.
you can run the test with
rebar3 ct --name something(the --name needs to be there)I see there was already a PR years ago for this problem: #8
In this change I try to collect from keys only from 2 nodes.