Update netlify config and DOCS #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessicaS11
reviewed
Jun 13, 2024
JessicaS11
reviewed
Jun 13, 2024
JessicaS11
reviewed
Jun 13, 2024
JessicaS11
reviewed
Jun 13, 2024
JessicaS11
reviewed
Jun 13, 2024
JessicaS11
reviewed
Jun 13, 2024
|
Thanks, @scottyhq! This is so awesome and helpful! |
spestana
reviewed
Jun 13, 2024
spestana
reviewed
Jun 13, 2024
Co-authored-by: Steven Pestana <[email protected]>
jomey
approved these changes
Jun 13, 2024
|
I tested Netlify and it kind of worked. It deployed but the GitHub Action failed because it doesn't have permission to create comments on issues. So I have to set something re permissions. 
I see the problem in the Workflow permissions, just not sure re solution 
|
|
Nevermind. Solved! This org is in Enterprise and the read/write was set at that level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minor update to netlify workflow (see Reduce clutter in PR preview deployment messages hackweeks-as-a-service#63)
lots of docs! closes Minimize required github secrets and document how to add them #81