Fix the sync-template action to work #159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After all the great additions last week, I tested the sync-to-template action on the tester repo. I ended up finding a few issues, fixed herein, as well as discovered a minor bug in the action itself. The PR opened by the action: https://github.com/ICESAT-2HackWeek/jupyterbook-template-tester/pull/2
A couple decision points:
cookiecutter.yaml
as one of our excluded files because it gets filled in with event info. But, it got updated in the last week's edits. I'm inclined to think the case where an excluded file is updated is not worth a custom solution (it would be easy enough to simply edit or delete the.templatesyncignore
file in the templated repo and run the action to open a PR with any changes). Thoughts? UPDATE: make any such changes manually or by triggering the update action from a branch with a modified.templatesyncignore
file.is_pr_cleanup
flag and it did not modify the open PR, just exited the action since the branch existed, so we're leaving as default.