-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Book - Simplify adding a team member #157
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An observed challenge over the years was to add many team members to the website at once without creating the dreaded merge conflict. This breaks up the monolithic `team.yaml` file and has each team member fill out their own. This hopefully makes it easier and has the nice side-effect of reusable files across hackweeks and years.
aaarendt
approved these changes
Mar 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome! I tested it locally and was able to add a new person seamlessly.
Co-authored-by: aaarendt <[email protected]>
Remove the 'icon_pack' key from the YAML file to simplify editing. The css key is now hard-coded to the HTML. Note that the current used version of fontawesome does not have an icon for X (aka Twitter) yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An observed challenge over the years was to add many team members to the website at once without creating the dreaded merge conflict. This breaks up the monolithic
team.yaml
file and has each team member fill out their own. This hopefully makes it easier and has the nice side-effect of reusable files across hackweeks and years.