Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Book - Simplify adding a team member #157

Merged
merged 4 commits into from
Mar 25, 2024
Merged

Book - Simplify adding a team member #157

merged 4 commits into from
Mar 25, 2024

Conversation

jomey
Copy link
Contributor

@jomey jomey commented Mar 23, 2024

An observed challenge over the years was to add many team members to the website at once without creating the dreaded merge conflict. This breaks up the monolithic team.yaml file and has each team member fill out their own. This hopefully makes it easier and has the nice side-effect of reusable files across hackweeks and years.

Copy link

github-actions bot commented Mar 23, 2024

@github-actions github-actions bot temporarily deployed to pull request March 23, 2024 00:45 Inactive
jomey added 2 commits March 25, 2024 09:33
An observed challenge over the years was to add many team members to the
website at once without creating the dreaded merge conflict. This breaks
up the monolithic `team.yaml` file and has each team member fill out
their own. This hopefully makes it easier and has the nice side-effect
of reusable files across hackweeks and years.
@jomey jomey force-pushed the add_team_members branch from 77c6701 to 9f680a1 Compare March 25, 2024 15:33
@github-actions github-actions bot temporarily deployed to pull request March 25, 2024 15:34 Inactive
Copy link
Contributor

@aaarendt aaarendt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! I tested it locally and was able to add a new person seamlessly.

team/README.md Outdated Show resolved Hide resolved
team/README.md Outdated Show resolved Hide resolved
team/template.yaml Outdated Show resolved Hide resolved
jomey and others added 2 commits March 25, 2024 13:34
Remove the 'icon_pack' key from the YAML file to simplify editing. The
css key is now hard-coded to the HTML.

Note that the current used version of fontawesome does not have an icon
for X (aka Twitter) yet.
@github-actions github-actions bot temporarily deployed to pull request March 25, 2024 19:51 Inactive
@jomey jomey merged commit e4576db into main Mar 25, 2024
5 checks passed
@jomey jomey deleted the add_team_members branch March 25, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants