eds working gravity with mapping bug #44
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balistreri0001
commented
Mar 26, 2024
| @@ -35,9 +35,10 @@ $setglobal gtap_version gtap11b | |||
| * Unless you want to update the default paths with new zip names * | |||
| * ---------------------------------------------------------------- * | |||
|
|
|||
| *NB_ejb: the string "333" must indicate the GTAP licensee. I need "1017" | |||
There was a problem hiding this comment.
This has changed because GTAP gives us different zip files base on something?
balistreri0001
commented
Mar 26, 2024
GTAPWiNDC/sugar_rpt.gms
Outdated
There was a problem hiding this comment.
ejb... I added this file as a report for a different project.
|
I've added myself as a review for this PR. That means before we merge this into the main gravity branch, I'll need to take a look at it. This is the GitHub analogue to peer review. Just let me know when you think it's ready and I'll take care of the rest. |
We have fixed the mapping bug. Still need work on the small numbers -- PATH has trouble with local replication apparently due to density of the bilateral trade flows which come from the gravity calculation.
Mapping bug fixed, but bilateral state-trade matrix is dense.
|
When you feel you have this finalized let me know and I can review and merge it into main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gravity as of January 2024, but with mapping bug