Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/comportdetection #26

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

mark11778
Copy link
Contributor

Have tested to make sure this works in all expected cases with the G9.

On a side note, the error/alarm red flashing light turns off once the connection is reestablished, sorry Brandon.

Will need to add the functionality for the VTRX subsystem and the Cathode Heating.

This does include a lot of the G9 branch files, let me know if I should remove them from this pull request

@mark11778
Copy link
Contributor Author

mark11778 commented Nov 17, 2024

Oh, keep in mind that when this branch is merged into develop you will have to remove usr/com_ports.json so the handle the new format.

@mslaffin
Copy link
Collaborator

This looks pretty solid.

I think we first have to clean this branch so that we're not merging outdated G9Driversim changes into develop. Makes it hard to review the detection/config storages changes in isolation.
git diff develop...feature/comportdetection

the easiest way might be:

  • create a clean branch starting from develop
  • cherry-pick only the comportdetection changes
  • basically delete this one

but if there's too much dependency, then we could wait for the G9 branch to be merged to develop, then rebase this on the updated develop.

Also need an attachment of the log file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants