-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete rewrite into modular package with CLI #3
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This commit is a squash of about 30 messy commits I made while creating a package structure for asp_plot. In those commits, I significantly restructured the code, added a command line interface, and added tests. I also added a few new notebooks and scripts for plotting and processing stereo data. I also added a few new tests for th
This is a huge PR that would be painful to review all of. Given that, I'm going to merge this as is. I am at the point where it is time to start working on smaller features, and having everything on this one giant PR isn't conducive to that clean work. Note: all of the old notebooks / code from the repo are preserved in the |
Major overhaul work in progress. Starting from first principles to build modular, reusable ASP plotting functionality. Much work to do, but I welcome comments on this PR along the way. Keeping it a draft for now, but eventually a detailed code review will come.
My goal (from slack message):
Overview plots:
Bundle Adjust plots:
Stereo plots:
vwip interest points on top of aligned (i.e. map-projected) L and R images (probably just use L_sub / R_sub) (tracking here: vwip interest points on top of aligned (i.e. map-projected) L and R images (probably just use L_sub / R_sub) #8)
L__R.match points on top of L_sub.tif image (don't see the need to plot full size L.tif)
D_sub.tif? Or RD.tif? Or F.tif? Benefit of D_sub is small size and not a virtual file, so not dependent on the thousands of sub-folders
DEM (overlain on HS) + IntErr; if DEMs produced at multiple postings then a separate plot for each
Difference map of DEM with command-line passed reference DEMs (could be COP30 always, but option to pass additional local DEMs, like 3DEP)
The figures are written into a markdown document and that markdown is converted to PDF at the end (maybe keeping the markdown around for manual editing, or just clean this up as well)
More things like metrics and descriptions of plots and exact commands that were run to output each step can be inserted into the markdown document as well. There might also be additional control flow and options for plots specific to pinhole cameras. But the framework of the command line tool would hopefully be easily re-usable and extendable.