Fixes for Umbra

uw-cryo · Nov 26, 2024 · 10bf955 · 10bf955
1 parent a63d1b0
commit 10bf955
Show file tree

Hide file tree

Showing 2 changed files with 290 additions and 1 deletion.
diff --git a/asp_plot/altimetry.py b/asp_plot/altimetry.py
@@ -530,7 +530,10 @@ def plot_atl06sr(
 
     def atl06sr_to_dem_dh(self):
         dem = rioxarray.open_rasterio(self.dem_fn, masked=True).squeeze()
-        epsg = dem.rio.crs.to_epsg()
+        # TODO: this won't work for 3D CRS contained in .tif.aux.xml
+        # Ah I see! We can reproject the ICESat-2 points/gdf to the CRS of the raster maybe, without using the to_epsg code to be safe.
+        # epsg = dem.rio.crs.to_epsg()
+        epsg = "PASS A VARIABLE"
         for key, atl06sr in self.atl06sr_processing_levels_filtered.items():
             atl06sr = atl06sr.to_crs(f"EPSG:{epsg}")
 
@@ -591,7 +594,10 @@ def mapview_plot_atl06sr_to_dem(
             symm_clim = True
 
         dem = rioxarray.open_rasterio(self.dem_fn, masked=True).squeeze()
+        # TODO: this won't work for 3D CRS contained in .tif.aux.xml
+        # Ah I see! We can reproject the ICESat-2 points/gdf to the CRS of the raster maybe, without using the to_epsg code to be safe.
         epsg = dem.rio.crs.to_epsg()
+        epsg = "PASS A VARIABLE"
 
         self.plot_atl06sr(
             key=key,

diff --git a/notebooks/icesat2_example_dem_comparisons.ipynb b/notebooks/icesat2_example_dem_comparisons.ipynb