Implement new sampler API and bump llama.cpp #580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
llama.cpp
introduces a new sampling API in b3680. This PR aims to replace the previous custom sampling API, with a wrapper around the newllama.cpp
sampling abstraction.We remove the custom sampling functions from
LlamaContext
, so this is a breaking change.Furthermore, we bump
llama.cpp
to b3750, which finalizes the newllama_perf
features, so we can more easily preserve the timings API.Credits to @brittlewis12, whose draft we copied in large parts. (#548)
It's probably worth it to squash commits before merging.
The new sampler is showcased in the
simple
example and can be used like this: