wrap llama_batch_get_one #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusDunn
reviewed
Nov 21, 2024
llama-cpp-2/src/llama_batch.rs
Outdated
| /// | ||
| pub fn get_one(tokens: &[LlamaToken], pos_0: llama_pos, seq_id: llama_seq_id) -> Self { | ||
| unsafe { | ||
| let ptr = tokens.as_ptr() as *mut i32; |
There was a problem hiding this comment.
Why does this need to be mut? If it doesn't, can you make a PR to llama-cpp instead of casting? If it does need to be mut, that should be reflected in the signature.
Also what are the implications of an empty slice here?
There was a problem hiding this comment.
#[repr(C)]
#[derive(Debug, Copy, Clone, PartialEq)]
pub struct llama_batch {
pub n_tokens: i32,
pub token: *mut llama_token,
pub embd: *mut f32,
pub pos: *mut llama_pos,
pub n_seq_id: *mut i32,
pub seq_id: *mut *mut llama_seq_id,
pub logits: *mut i8,
pub all_pos_0: llama_pos,
pub all_pos_1: llama_pos,
pub all_seq_id: llama_seq_id,
}
The orignal field token is mut.
Yes, the slice should not be empty.
MarcusDunn
approved these changes
Nov 27, 2024
|
included in latest, thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrap llama_cpp_sys_2::llama_batch_get_one and safer drop