Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GNSS receiver ini file #597

Merged
merged 13 commits into from
Mar 12, 2024
Merged

Fix GNSS receiver ini file #597

merged 13 commits into from
Mar 12, 2024

Conversation

200km
Copy link
Member

@200km 200km commented Feb 6, 2024 •
edited
Loading

Related issues

#276

Description

I modified the ini file interface for GNSS receiver.

  • Modify to use string to set antenna_model
  • Rename gnss_id to gnss_system_id
  • Modify the frame definition of random noise ECI -> ECEF
  • Add velocity random noise
  • Remove ECI observation value because the most of the GNSS receiver observe ECEF frame
    • Users who want to know ECI satellite position observation can use position observer

Test results

NA

Impact

NA

Supplementary information

NA

@200km 200km added priority::medium priority medium component component emulation major update incompatible API changes labels Feb 6, 2024
@200km 200km added this to the Major Update v8.0.0 milestone Feb 6, 2024
@200km 200km self-assigned this Feb 6, 2024
@200km 200km requested review from sksat and a team as code owners February 6, 2024 15:58
@200km 200km requested review from suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team February 6, 2024 15:58
Base automatically changed from feature/use-geodetic-position to feature/refactor-gnss-receiver February 7, 2024 05:18
@200km 200km changed the title [WIP] Fix GNSS receiver ini file Fix GNSS receiver ini file Feb 7, 2024
@200km 200km mentioned this pull request Feb 7, 2024
Merged
@200km 200km requested a review from seki-hiro February 8, 2024 14:47
suzuki-toshihir0
suzuki-toshihir0 approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@suzuki-toshihir0 suzuki-toshihir0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

かなり遅くなってしまいすみません。。。問題ないと思いますので、approveします。

@200km 200km merged commit 5505198 into feature/refactor-gnss-receiver Mar 12, 2024
11 checks passed
@200km 200km deleted the feature/fix-gnss-receiver-ini-file branch March 12, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzuki-toshihir0 suzuki-toshihir0 suzuki-toshihir0 approved these changes

@sksat sksat Awaiting requested review from sksat

@t-hosonuma t-hosonuma Awaiting requested review from t-hosonuma t-hosonuma was automatically assigned from ut-issl/aocs

@conjikidow conjikidow Awaiting requested review from conjikidow conjikidow was automatically assigned from ut-issl/aocs

@seki-hiro seki-hiro Awaiting requested review from seki-hiro

Assignees

@200km 200km

Labels
component component emulation major update incompatible API changes priority::medium priority medium
Projects
S2E
Archived in project
Milestone
Major Update v8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@200km @suzuki-toshihir0