-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/#71 login #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ๊ณ ์ํ์ จ์ต๋๋ค! ๋ชจ๋ฅด๋ ๋ถ๋ฌธ์ด ์์ด ์ง๋ฌธ ๋จ๊ฒผ์ต๋๋ค
|
||
fun onShowToast(msg: String) = intent { | ||
viewModelScope.launch { | ||
mutex.withLock { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
์๋ถ๋ถ์ด ์๊ณ๊ตฌ์ญ์ ๋ง๋๋ ๋ถ๋ถ์ธ๊ฐ์? ์ด ์ฝ๋ ์ฌ์ฉ ์ด์ ๊ฐ ๊ถ๊ธํฉ๋๋ค
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๋ค ๋ง์์.
onShowToast ๋ฉ์๋๋ฅผ 0.1์ด ๊ฐ๊ฒฉ์ผ๋ก ํธ์ถํ๊ฒ ๋๋ฉด ์ค๊ฐ์ ๋๋ฝ๋๋ ๊ฒฝ์ฐ๊ฐ ์์ด์ mutex๋ก ๋ฐฉ์ดํด์คฌ์ต๋๋ค~!
@Composable | ||
fun LectureEvaluationScreen( | ||
fun LectureEvaluationRoute( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Route์ Screen์ ๋๋ ์ด์ ๊ฐ ๊ถ๊ธํฉ๋๋ค!
Screen์ ํ๋ฉด์ ๊ทธ๋ ค์ฃผ๋ ์ญํ ๋ง ํ๋๊ฑด๊ฐ์???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview์ viewmodel์ ๋ชป๋ฃ์ด์ค์ ๋ถ๋ฆฌํ์ด์ฉ
fun hideEmailNotAuthDialog() = intent { reduce { state.copy(showEmailNotAuthDialog = false) } } | ||
|
||
@OptIn(OrbitExperimental::class) | ||
fun updateId(id: String) = blockingIntent { reduce { state.copy(id = id) } } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blockingIntent
์ฌ์ฉํ ์ด์ ๊ฐ ๊ถ๊ธํฉ๋๋ค~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
orbit ๋ฌธ์๋ณด๋ฉด ํ ์คํธ ์ธํ ๊ฐ์ ๊ฒฝ์ฐ์๋ blockingIntent ์ฌ์ฉํ๋ผ๊ณ ๋์ด์๋๋ผ๊ตฌ์. ๊ทธ๋ฅ intent ์ฌ์ฉํ๋ฉด ์ฑํ ์ ๋ ฅ์ด ๋๋ฝ๋๋ ๊ฒฝ์ฐ๊ฐ ์ข ์์ด์
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
๊ณ ์ํ์ จ์ต๋๋ค~!! ๐๐
๐ PR ์์ฝ
๐ฑ ์์ ํ ๋ด์ฉ
๐ฑ PR ํฌ์ธํธ
๐ธ ์คํฌ๋ฆฐ์ท
๐ฎ ๊ด๋ จ ์ด์