Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#71 login #74

Merged
merged 9 commits into from
Dec 28, 2023
Merged

Feature/#71 login #74

merged 9 commits into from
Dec 28, 2023

Conversation

jinukeu
Copy link
Member

@jinukeu jinukeu commented Dec 27, 2023

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ๋กœ๊ทธ์ธ ์ž‘์—…ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ์•„์ด๋”” ์ฐพ๊ธฐ, ๋น„๋ฐ€๋ฒˆํ˜ธ ์ฐพ๊ธฐ, ํšŒ์›๊ฐ€์ž… ๊ธฐ๋Šฅ๊นŒ์ง€ ์ถ”๊ฐ€ํ•˜๋ฉด ๋„ˆ๋ฌด ๋งŽ์•„์งˆ ๊ฒƒ๊ฐ™์•„ ์šฐ์„  PR ์˜ฌ๋ฆฝ๋‹ˆ๋‹ค.

๐ŸŒฑ PR ํฌ์ธํŠธ

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
แ„…แ…ฉแ„€แ…ณแ„‹แ…ตแ†ซpr

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@jinukeu jinukeu requested review from lsakee and BEEEAM-J December 27, 2023 09:31
@jinukeu jinukeu self-assigned this Dec 27, 2023
Copy link
Contributor

@lsakee lsakee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค! ๋ชจ๋ฅด๋Š” ๋ถ€๋ฌธ์ด ์žˆ์–ด ์งˆ๋ฌธ ๋‚จ๊ฒผ์Šต๋‹ˆ๋‹ค


fun onShowToast(msg: String) = intent {
viewModelScope.launch {
mutex.withLock {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์š”๋ถ€๋ถ„์ด ์ž„๊ณ„๊ตฌ์—ญ์„ ๋งŒ๋“œ๋Š” ๋ถ€๋ถ„์ธ๊ฐ€์š”? ์ด ์ฝ”๋“œ ์‚ฌ์šฉ ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ค ๋งž์•„์š”.
onShowToast ๋ฉ”์„œ๋“œ๋ฅผ 0.1์ดˆ ๊ฐ„๊ฒฉ์œผ๋กœ ํ˜ธ์ถœํ•˜๊ฒŒ ๋˜๋ฉด ์ค‘๊ฐ„์— ๋ˆ„๋ฝ๋˜๋Š” ๊ฒฝ์šฐ๊ฐ€ ์žˆ์–ด์„œ mutex๋กœ ๋ฐฉ์–ดํ•ด์คฌ์Šต๋‹ˆ๋‹ค~!

@Composable
fun LectureEvaluationScreen(
fun LectureEvaluationRoute(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Route์™€ Screen์„ ๋‚˜๋ˆˆ ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค!
Screen์€ ํ™”๋ฉด์„ ๊ทธ๋ ค์ฃผ๋Š” ์—ญํ• ๋งŒ ํ•˜๋Š”๊ฑด๊ฐ€์š”???

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview์— viewmodel์„ ๋ชป๋„ฃ์–ด์ค˜์„œ ๋ถ„๋ฆฌํ–ˆ์–ด์šฉ

fun hideEmailNotAuthDialog() = intent { reduce { state.copy(showEmailNotAuthDialog = false) } }

@OptIn(OrbitExperimental::class)
fun updateId(id: String) = blockingIntent { reduce { state.copy(id = id) } }
Copy link
Member

@BEEEAM-J BEEEAM-J Dec 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blockingIntent์‚ฌ์šฉํ•œ ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค~

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

orbit ๋ฌธ์„œ๋ณด๋ฉด ํ…์ŠคํŠธ ์ธํ’‹ ๊ฐ™์€ ๊ฒฝ์šฐ์—๋Š” blockingIntent ์‚ฌ์šฉํ•˜๋ผ๊ณ  ๋˜์–ด์žˆ๋”๋ผ๊ตฌ์š”. ๊ทธ๋ƒฅ intent ์‚ฌ์šฉํ•˜๋ฉด ์ฑ„ํŒ… ์ž…๋ ฅ์ด ๋ˆ„๋ฝ๋˜๋Š” ๊ฒฝ์šฐ๊ฐ€ ์ข€ ์žˆ์–ด์š”

Copy link
Member

@BEEEAM-J BEEEAM-J left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค~!! ๐Ÿ‘๐Ÿ‘

@jinukeu jinukeu merged commit 9d9660c into develop Dec 28, 2023
1 check passed
@jinukeu jinukeu deleted the feature/#71-login branch January 8, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feat] Login
3 participants