-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds external interface testing for PQC algos #1551
Open
celic
wants to merge
3
commits into
master
Choose a base branch
from
FEATURE/PqcExternalInterfaces
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of hashes looks overly permissive (more than the lambda * 2). Is the server restricting the hashes for pre-hashed variants? Also, why are there 2 interface type definitions? IMHO there should only be one, no? Internal, external and externallmu. Also, would it make sense to drop the prehash keyword and the presence of hash algos indicates prehash, no? |
The full list of hashes is allowed. It would weaken the security strength
of the signature, but all hashes are allowed for all key sizes.
It makes things a bit easier this way for SLH-DSA and ML-DSA in terms of
code but it's an arbitrary decision. We're ok including extra properties to
describe things. We prefer that test group properties tell you what
properties to expect rather than a client checking to see what properties
are there.
…On Thu, Jan 9, 2025, 1:06 PM smuellerDD ***@***.***> wrote:
The list of hashes looks overly permissive (more than the lambda * 2). Is
the server restricting the hashes for pre-hashed variants?
Also, why are there 2 interface type definitions? IMHO there should only
be one, no? Internal, external and externallmu.
Also, would it make sense to drop the prehash keyword and the presence of
hash algos indicates prehash, no?
—
Reply to this email directly, view it on GitHub
<#1551 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AATQXEMFDTFJQKLSYWVCQOT2J23CFAVCNFSM6AAAAABU3BGUDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKOBQHE2DSNRRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
livebe01
reviewed
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.