-
-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix https://github.com/usmannasir/cyberpanel/issues/842 #1155
Conversation
Noticed the ip file is read within |
I'm unsure as to why |
Though not directly related to your PR, Issue #1145 I've opened deals with fixing JSON in the cloudApi which does relate to your previously opened Issue #842. Would be nice to get some feedback from the team on this as I've observed fixing the JSON handling also fixed some other minor errors thrown in the dashboard. |
I had to change the base for this merge, thanks. |
Would you also accept cleaning up the rest of the CLI file to catch issues like this? I'd make separate issues if needed as well. |
You have any pending PR? If now I've no problem reviewing new and merging. thank you.
|
Not currently, but it'll be worked on this week. Glad to help! 👍
|
Here to help. |
As said in #842 (comment) , there's no reason not to have this as a list.