Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix https://github.com/usmannasir/cyberpanel/issues/842 #1155

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Fix https://github.com/usmannasir/cyberpanel/issues/842 #1155

merged 2 commits into from
Nov 22, 2023

Conversation

Lvl4Sword
Copy link
Contributor

As said in #842 (comment) , there's no reason not to have this as a list.

@Lvl4Sword
Copy link
Contributor Author

Lvl4Sword commented Nov 17, 2023

Noticed the ip file is read within listWebsitesJson, but is never closed.
with open() ensures the file is closed without needing to explicitly call .close()

@Lvl4Sword
Copy link
Contributor Author

Lvl4Sword commented Nov 17, 2023

I'm unsure as to why checker is here, let alone why the ip file is even being read, since neither seem to really be used for anything. since it doesn't seem to be used. The ip is used, because that needs provided to the user.. lol

@Lvl4Sword Lvl4Sword mentioned this pull request Nov 17, 2023
44 tasks
@xmok
Copy link
Contributor

xmok commented Nov 17, 2023

Though not directly related to your PR, Issue #1145 I've opened deals with fixing JSON in the cloudApi which does relate to your previously opened Issue #842. Would be nice to get some feedback from the team on this as I've observed fixing the JSON handling also fixed some other minor errors thrown in the dashboard.

@usmannasir usmannasir changed the base branch from stable to v2.3.5-dev November 22, 2023 04:32
@usmannasir
Copy link
Owner

I had to change the base for this merge, thanks.

@usmannasir usmannasir closed this Nov 22, 2023
@usmannasir usmannasir reopened this Nov 22, 2023
@usmannasir usmannasir merged commit 589f87a into usmannasir:v2.3.5-dev Nov 22, 2023
1 check passed
@Lvl4Sword
Copy link
Contributor Author

Would you also accept cleaning up the rest of the CLI file to catch issues like this? I'd make separate issues if needed as well.

@usmannasir
Copy link
Owner

You have any pending PR?

If now I've no problem reviewing new and merging.

thank you.

Would you also accept cleaning up the rest of the CLI file to catch issues like this? I'd make separate issues if needed as well.

@Lvl4Sword
Copy link
Contributor Author

Not currently, but it'll be worked on this week. Glad to help! 👍

You have any pending PR?

If now I've no problem reviewing new and merging.

thank you.

Would you also accept cleaning up the rest of the CLI file to catch issues like this? I'd make separate issues if needed as well.

@usmannasir
Copy link
Owner

Here to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants