Minecraft 1.20.6 Update #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Muspah I have marked this as a draft for now - it would be great to get a second pair of eyes on this, as the changes are involved. I tested it on our local setup, and everything looks good, but testing on another independent setup would be good. Diff of the actual update: minoneer/uSkyBlock@a1742af...minoneer:uSkyBlock:minecraft-1.20.6 |
Includes code cleanup of left-over pre-1.13 stuff
- move parsing code to factory & item utils where all the other parsing occurs - decouple requirement amount from stack size. We should not rely on ItemStack being able to have larger amounts than maxStackSize - change parsing to use item components instead of nbt tags - including tests - cleanup code
- The converter converts all challenges to the new item format. - Item meta from the default challenges configuration are automatically converted. - Other item meta is moved to the comments and will have to be converted manually. - The explanation is moved to the config header, instead of a comment on the version number.
These were used previously as defaults and may not have been updated.
minoneer
force-pushed
the
minecraft-1.20.6
branch
from
56a59eb to
54249ba
Compare
|
Rebased onto bukkit-utils merge in master |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for Minecraft/Spigot/Paper 1.20.6
Vanilla-Minecraft changes how items are stored and specified in 1.20.5. Since items are a central part of uSkyBlock, it requires extensive changes.
This PR depends on #54 - once that is merged, the diff should become a lot cleaner and more readable.