Improve rename refactoring name check #533

toinehartman · 2024-11-27T13:28:14Z

This PR improves the user experience when trying to rename to an invalid name.

Before checking the validity of the new name based on the type of declarations, perform a quick check based on only the location in the parse tree. Since this does not require any type information, this can be performed early and efficiently, informing the user as soon as possible when the renaming will not succeed.
Fix the type of exceptions thrown by the rename refactoring, so VS Code shows it once (instead of twice).

Closes #517.

sonarcloud · 2024-11-27T13:55:17Z

Quality Gate passed

toinehartman added 2 commits November 27, 2024 14:03

Check early (loosely) whether entered name is valid.

92c2dbe

Change exception type, so the exception shows it just once.

c60bd76

toinehartman added the bug Something isn't working label Nov 27, 2024

toinehartman requested a review from sungshik November 27, 2024 13:28

toinehartman self-assigned this Nov 27, 2024

PieterOlivier approved these changes Nov 27, 2024

View reviewed changes

Check for validity of escaped name.

4fa9c79

toinehartman merged commit 0a8f478 into main Nov 27, 2024
13 checks passed

toinehartman deleted the fix/rename-refactoring/invalid-name-check branch November 27, 2024 14:29