Rename performance improvements

[toinehartman]

After testing with large Rascal projects (rascal-core, typepal), some low-hanging performance improvements to the rename refactoring presented themselves. Otherwise, the rename refactoring now mainly spends time in the type checker, which has some performance improvements under development.

This code prevents a stack overflow when renaming names in rascal-core and vastly reduces the time needed to determine overflows of a given definition.

[DavyLandman]

Good that you tackled a few of the causes of slowdown 👍🏼

As a general performance tip:

if (x <- [0..9999], x % 33 == 0) { return x; }

is correct, but written as a loop doesn't lean on the backtracker to do the iteration.

for (x <- [0..9999], x % 33 == 0) { return x; }

will often be faster, or even this (which is slighly slower, but sometimes leads to better readable code):

for (x <- [0..9999]) { if (x % 33 == 0) return x; }

[toinehartman]

a loop doesn't lean on the backtracker to do the iteration

@DavyLandman Thanks, will keep that in mind and apply it when refactoring the renaming code later on.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud