Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic tokenizer tests #494

Merged

Conversation

sungshik
Copy link
Contributor

@sungshik sungshik commented Oct 30, 2024

Before this PR, there were no unit(-ish) tests for the semantic tokenizer yet. In anticipation of a fix for #456, this PR adds a few basic tests so we can detect regression (including tests for issues that were fixed long ago).

Copy link
Contributor Author

@sungshik sungshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional comments

@sungshik sungshik marked this pull request as ready for review October 30, 2024 14:39
@sungshik sungshik changed the title Add tests for the semantic highlighter Add tests for the semantic tokenizer Oct 30, 2024
@sungshik sungshik marked this pull request as draft October 30, 2024 14:59
@sungshik sungshik force-pushed the semantic-tokenizer-fall2024-tests branch from 833c264 to c52aff9 Compare October 30, 2024 16:36
Copy link
Contributor Author

@sungshik sungshik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional additional comments

@sungshik sungshik marked this pull request as ready for review October 30, 2024 16:40
@sungshik sungshik changed the title Add tests for the semantic tokenizer Add semantic tokenizer tests Oct 30, 2024
Copy link
Contributor

@toinehartman toinehartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice concise, readable, tests. Good stuff!

Copy link

sonarcloud bot commented Nov 1, 2024

@sungshik sungshik merged commit a69585c into semantic-tokenizer-fall2024 Nov 1, 2024
13 checks passed
@sungshik sungshik deleted the semantic-tokenizer-fall2024-tests branch November 6, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants