-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A consistent naming scheme for the LanguageService constructors , with backward compatibility functions. #473
Conversation
…ouns did not work. Instead these are all proper adjectives to the word "service". E.g. "parsing service" and "references service" and "build service"
…d new ones for parsing, build, analysis and execution services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great to make this more consistent! I added a few comments, but essentially, my two remaining questions are these:
- Should we also rename arguments to make them consistent with constructors? (e.g., the argument of
hover
is nowdocumentor
) - Should we also rename everything (well...) in the Java code?
I don't have strong opinions on these questions; just want to raise them for consideration. See the comments for details.
rascal-lsp/src/main/rascal/demo/lang/pico/NewLanguageServer.rsc
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/rascal/demo/lang/pico/NewLanguageServer.rsc
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/rascal/demo/lang/pico/NewLanguageServer.rsc
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/rascal/demo/lang/pico/NewLanguageServer.rsc
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/model/RascalADTs.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're getting close to a new set of names, but still require some tweaking (most of my comments are replies to points of @sungshik, so better to read it in the "Files Changed" tab).
rascal-lsp/src/main/java/org/rascalmpl/vscode/lsp/parametric/model/RascalADTs.java
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/rascal/demo/lang/pico/NewLanguageServer.rsc
Outdated
Show resolved
Hide resolved
rascal-lsp/src/main/rascal/demo/lang/pico/NewLanguageServer.rsc
Outdated
Show resolved
Hide resolved
Co-authored-by: sungshik <[email protected]>
…ummary.documentation to Summary.hovers and added documentation about the specific language services that used to be with the aliases
…ith LSP" This reverts commit f386f58.
…sistent-service-names-java
…es-flaky-test More consistent service names flaky test
…usly overlooked)
…es-java Rename Java identifiers to be consistent with LSP
…r to LanguageServer in the pico demo and added documentation to reflect it
Quality Gate passedIssues Measures |
This renames allmost all language services towards consistency.
All verbs or all nouns did not work.
Instead these are all proper adjectives to the word "service". E.g. "parsing service" and "references service" and "build service". This is also the scheme of the original LSP services. The new scheme is also consistent with the names in
Summary
of the cached output of the respective lazy services.This changes:
parser
toparsing
.. servicebuilder
tobuild
.. serviceTODO's: