Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DEV-878] Handle disabled state for no first factors #96

Merged
merged 2 commits into from
Jan 10, 2024
Merged

[DEV-878] Handle disabled state for no first factors #96

merged 2 commits into from
Jan 10, 2024

Conversation

isanchez-userfront
Copy link
Contributor

@isanchez-userfront isanchez-userfront commented Jan 9, 2024 •
edited
Loading

Resolves DEV-878

Description

  • Change the @userfront/toolkit dependency under site to ensure use of the workspace.
  • Add an error disabled state which is used when there are no first factors.

@vercel Vercel
Copy link

vercel bot commented Jan 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vercel-toolkit-react-dev-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 0:26am
vercel-toolkit-react-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 0:26am

@isanchez-userfront isanchez-userfront force-pushed the feature/dev-878-toolkit-should-handle-empty-first-factors branch from 67e3f91 to 99bea1f Compare January 9, 2024 16:17
@isanchez-userfront isanchez-userfront force-pushed the feature/dev-878-toolkit-should-handle-empty-first-factors branch from 99bea1f to ac1c8d5 Compare January 9, 2024 16:24
@isanchez-userfront isanchez-userfront force-pushed the feature/dev-878-toolkit-should-handle-empty-first-factors branch from ac1c8d5 to c487878 Compare January 9, 2024 16:26
@isanchez-userfront isanchez-userfront force-pushed the feature/dev-878-toolkit-should-handle-empty-first-factors branch from c487878 to b05572c Compare January 9, 2024 16:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024 •
edited
Loading

Coverage Summary for `package`

Status Category Percentage Covered / Total
🔵 Lines 68.76% 3192 / 4642
🔵 Statements 68.76% 3192 / 4642
🔵 Functions 49.43% 88 / 178
🔵 Branches 60.78% 124 / 204
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
package/src/components/AlternativeButton.jsx 69.23% 100% 0% 69.23% 8-11
package/src/components/BackButton.jsx 39.47% 100% 0% 39.47% 14-36
package/src/components/ContinueButton.jsx 47.36% 100% 0% 47.36% 8-17
package/src/components/Divider.jsx 54.16% 100% 0% 54.16% 12-22
package/src/components/ErrorMessage.jsx 92.59% 33.33% 100% 92.59% 16-17
package/src/components/IconButton.jsx 28.57% 100% 0% 28.57% 15-16, 19-28, 47-136, 147-159
package/src/components/InfoMessage.jsx 45.83% 100% 0% 45.83% 10-22
package/src/components/PhoneNumberInput.jsx 69.44% 0% 0% 69.44% 24-34
package/src/components/RetryButton.jsx 61.11% 100% 0% 61.11% 10-16
package/src/components/SecuredByUserfront.jsx 100% 100% 100% 100%
package/src/components/SubmitButton.jsx 100% 100% 100% 100%
package/src/components/TestModeNotice.jsx 66.66% 50% 50% 66.66% 16-18, 20-21, 28-34
package/src/components/Input/BackupCodeInput.jsx 100% 100% 100% 100%
package/src/components/Input/BaseInput.jsx 93.54% 33.33% 100% 93.54% 27-28
package/src/components/Input/EmailInput.jsx 100% 100% 100% 100%
package/src/components/Input/EmailOrUsernameInput.jsx 100% 100% 100% 100%
package/src/components/Input/PasswordInput.jsx 90.9% 0% 0% 90.9% 20-23
package/src/components/Input/TotpCodeInput.jsx 100% 100% 100% 100%
package/src/components/Input/VerificationCodeInput.jsx 100% 100% 100% 100%
package/src/components/Input/index.jsx 88% 100% 50% 88% 23-25
package/src/forms/UniversalForm.jsx 52.28% 7.27% 100% 52.28% 173-175, 191-209, 211-217, 219-229, 231-243, 249-259, 261-273, 277-284, 296-302, 304-310, 312-318, 322-326, 328-334, 336-340, 342-348, 350-354, 358-362, 364-370, 372-376, 378-384, 386-390, 394-398, 400-406, 408-411, 415-428, 430-443, 445-449, 453-459, 461-467, 469-475, 477-483, 485-489, 492-496, 503-507, 511-515, 528-535, 538-541, 545-548, 552-556
package/src/models/config/actions.ts 67% 97.82% 89.74% 67% 63-77, 79-92, 96-101, 130-131, 159-169, 174-180, 196-201, 207-213, 218-222, 229-235, 243-248, 265-266, 283-285, 313-326, 338-339, 351-355, 375-376, 379-394
package/src/models/config/guards.ts 80.15% 100% 55.88% 80.15% 44, 48, 55-60, 68, 73, 78, 85-91, 96, 101, 106-107, 117, 121, 125
package/src/models/config/utils.ts 91.71% 100% 78.57% 91.71% 108-118, 123-124, 134
package/src/models/forms/universal.ts 91.35% 100% 4.76% 91.35% 95-97, 99-101, 126-131, 136-137, 167-172, 176-177, 179-180, 182-183, 185-186, 188-189, 191-192, 243, 329-335, 640-648, 662-672, 778-785
package/src/models/views/emailCode.ts 96.8% 50% 100% 96.8% 37-38, 40-41
package/src/models/views/emailLink.ts 88.23% 28.57% 100% 88.23% 37-42, 49-50, 52-53, 94-95, 97-98
package/src/models/views/password.ts 75.26% 100% 0% 75.26% 42-64
package/src/models/views/selectFactor.ts 100% 100% 100% 100%
package/src/models/views/setNewPassword.ts 78.94% 100% 0% 78.94% 35-50
package/src/models/views/setUpTotp.ts 89.91% 100% 0% 89.91% 55-66
package/src/models/views/smsCode.ts 96.87% 50% 100% 96.87% 40-41, 43-44
package/src/models/views/totpCode.ts 66.66% 100% 0% 66.66% 37-61, 89-109
package/src/services/logging.js 38.46% 100% 0% 38.46% 5-6, 9-10, 13-15, 18-26
package/src/services/userfront.ts 65.88% 53.33% 60% 65.88% 49-62, 74-78, 83-85, 101-102, 104-108, 111-113, 128-129, 147-170
package/src/utils/hooks.js 80% 77.77% 100% 80% 12, 19-20, 22-23
package/src/views/AlreadyLoggedIn.jsx 77.77% 100% 0% 77.77% 6-7
package/src/views/EmailLinkSent.jsx 50% 100% 0% 50% 15-30
package/src/views/EnterEmail.jsx 71.42% 50% 50% 71.42% 20-33
package/src/views/EnterPhone.jsx 42.1% 100% 0% 42.1% 15-36
package/src/views/EnterTotpCode.jsx 18.11% 100% 0% 18.11% 22-125
package/src/views/EnterVerificationCode.jsx 34.78% 100% 0% 34.78% 15-44
package/src/views/GeneralErrorMessage.jsx 56.52% 100% 0% 56.52% 12-21
package/src/views/LogInWithPassword.jsx 28.33% 100% 0% 28.33% 16-58
package/src/views/Message.jsx 81.81% 100% 0% 81.81% 8-9
package/src/views/Placeholder.jsx 75% 100% 0% 75% 5-6
package/src/views/SelectFactor.jsx 26.8% 100% 0% 26.8% 25-95
package/src/views/SetNewPassword.jsx 62.36% 100% 50% 62.36% 19-53
package/src/views/SetNewPasswordSuccess.jsx 75% 100% 0% 75% 5-6
package/src/views/SetUpTotp.jsx 34.61% 100% 0% 34.61% 17-50
package/src/views/SetUpTotpSuccess.jsx 36.11% 100% 0% 36.11% 12-34
package/src/views/SignUpWithPassword.jsx 20.4% 100% 0% 20.4% 19-96
package/src/views/Success.jsx 50% 100% 0% 50% 10-20
package/src/views/TotpErrorMessage.jsx 48.48% 100% 0% 48.48% 15-31

@isanchez-userfront isanchez-userfront force-pushed the feature/dev-878-toolkit-should-handle-empty-first-factors branch from b05572c to 5db4993 Compare January 9, 2024 16:31
RJFelix
RJFelix suggested changes Jan 9, 2024
View reviewed changes
package/src/models/forms/universal.ts Outdated Show resolved Hide resolved
package/src/forms/UniversalForm.jsx Outdated Show resolved Hide resolved
package/src/models/forms/universal.ts Outdated Show resolved Hide resolved
@isanchez-userfront isanchez-userfront force-pushed the feature/dev-878-toolkit-should-handle-empty-first-factors branch from 5db4993 to 8620922 Compare January 10, 2024 00:09
@isanchez-userfront isanchez-userfront force-pushed the feature/dev-878-toolkit-should-handle-empty-first-factors branch from 8620922 to 42435ea Compare January 10, 2024 00:20
@isanchez-userfront isanchez-userfront marked this pull request as ready for review January 10, 2024 00:56
@isanchez-userfront isanchez-userfront merged commit 85f2eba into main Jan 10, 2024
3 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Published version 1.0.6-alpha.1 to npm.

@stephencattaneo stephencattaneo deleted the feature/dev-878-toolkit-should-handle-empty-first-factors branch August 20, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RJFelix RJFelix RJFelix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isanchez-userfront @RJFelix