-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Never redirect after login when setting up TOTP #107
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the bug, thanks - see my question about whether we need to redirect within Toolkit after they're done with their backup codes, though!
} | ||
|
||
// Don't redirect after TOTP setup so backup codes can be shown | ||
arg.redirect = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to explicitly redirect after they confirm they've gotten the codes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It redirects to the after signup path after you hit continue.
Published version 1.0.8-alpha.0 to npm. |
Review Level: Glance
Closes: DEV-1085
Never redirect after login when setting up TOTP. Had to move the argument out of the if statement.