overlapping subjs optimization that idk why i didn't try before

watch me discover why i didn't try this before as i commit a revert in 20 mins
user5522 · Jun 3, 2024 · b5856c0 · b5856c0
1 parent 0480302
commit b5856c0
Showing 1 changed file with 2 additions and 12 deletions.
diff --git a/lib/components/timetable_views/grid_view.dart b/lib/components/timetable_views/grid_view.dart
@@ -65,18 +65,6 @@ class TimetableGridView extends HookConsumerWidget {
       },
     ).toList();
 
-    /// this basically finds overlapping subjects and puts them in the overlapping subjects [StateNotifier]
-    Future.delayed(
-      Duration.zero,
-      () async {
-        final overlappingSubjectsNotifier =
-            ref.read(overlappingSubjectsProvider.notifier);
-
-        overlappingSubjectsNotifier
-            .addInBulk(findOverlappingSubjects(subjects));
-      },
-    );
-
     final double screenWidth = MediaQuery.of(context).size.width;
     final bool isPortrait =
         MediaQuery.of(context).orientation == Orientation.portrait;
@@ -149,6 +137,8 @@ class TimetableGridView extends HookConsumerWidget {
       ),
     );
 
+    overlappingSubjects.addAll(findOverlappingSubjects(subjects));
+
     // overlapping subjects
     if (overlappingSubjects.isNotEmpty &&
         overlappingSubjects.any(