fix: Chrome rejects refresh_token cookie in cross-origin requests due to missing SameSite attribute. #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sun
changed the title
|
Sorry for not getting to this earlier. 😬 Your proposed change looks good to me. We could move forward with it – although Google is now stating that we should implement other/additional measures in the meantime:
Do we want to investigate that here or in a separate issue/PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chrome prohibits the refresh_token cookie from being set from cross-origin requests because it is missing the samesite attribute.
Things to consider:
Laxmaybe this could even be set toStrictas the refresh_token is probably only used on subsequent requests in a first-party context when not cross-origin.