Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Graceful handle rename/move: Fix EPERM Error When Renaming Parent Folders on Windows #3236

Merged

Conversation

Pragadesh-45
Copy link
Contributor

fixes: #678 #3235

Description

This PR implements the feature to gracefully handle recursive folder renaming/moving by using a temporary directory in memory. Since this fix is needed only for Windows and there are no known issues with WSL or network paths, it is addressed as needed.

Changes made:

  • Added isWindowsOS() utility function to check the OS type.
  • Implemented tempDir logic to gracefully rename the parent folder.
  • Added conditional checks to trigger the copy/move/delete algorithm only when necessary to improve performance.

Contribution Checklist:

  • The pull request addresses only one issue or adds one feature.
  • The pull request does not introduce any breaking changes.
  • I have added screenshots or GIFs to help explain the change, if applicable.
  • I have read the contribution guidelines.
  • Created an issue and linked it to the pull request.

Before:

20241001-0947-49.3882630.mp4

After:

20241001-1002-09.6069246.mp4

@Pragadesh-45 Pragadesh-45 marked this pull request as ready for review October 1, 2024 11:27
@helloanoop helloanoop merged commit f2cfcab into usebruno:main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Unable to rename folder due to lock hold by Bruno.exe process
2 participants