Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ink! 5 #298

Merged
merged 13 commits into from
Feb 23, 2024
Merged

Update to ink! 5 #298

merged 13 commits into from
Feb 23, 2024

Conversation

smiasojed
Copy link
Contributor

@smiasojed smiasojed commented Jan 31, 2024

Update contract to ink5
Update CI
Add tests
Rename constructor from default to new

Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for inklink canceled.

Name Link
🔨 Latest commit 9a59370
🔍 Latest deploy log https://app.netlify.com/sites/inklink/deploys/65d5dfba2d69c5000870f861

@smiasojed smiasojed marked this pull request as ready for review February 1, 2024 09:51
@peetzweg
Copy link
Collaborator

peetzweg commented Feb 1, 2024

Nice! Had this on my list for refreshing this dapp.

However, it's just the contract source which is updated to v5, the actual v3 contract is still deployed and used by the dapp afaik.

The contract seems to have a feature to be updated, do we want to upgrade it to v5? Otherwise we dapp still needs the metadata from v3 to work properly as well as polkadotjs is not yet ready for v5. Might lead to crashes if we just upgrade the contract without adapted the frontend with the updated pjs just yet.

@cmichi
Copy link
Collaborator

cmichi commented Feb 1, 2024

However, it's just the contract source which is updated to v5, the actual v3 contract is still deployed and used by the dapp afaik.

The contract seems to have a feature to be updated, do we want to upgrade it to v5? Otherwise we dapp still needs the metadata from v3 to work properly as well as polkadotjs is not yet ready for v5. Might lead to crashes if we just upgrade the contract without adapted the frontend with the updated pjs just yet.

So far it's only deployed on Rococo, so we can just ignore the running instance. I told Sebastian that you would take care of switching the frontend to ink!athon/useInkathon.

@smiasojed smiasojed merged commit cda614e into master Feb 23, 2024
10 checks passed
@smiasojed smiasojed deleted the sm/ink5 branch February 23, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants