Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating the measurement and publish workflows to GitHub Actions #1971

Merged
merged 16 commits into from
Nov 13, 2023

Conversation

smiasojed
Copy link
Collaborator

@smiasojed smiasojed commented Nov 3, 2023

Summary

Related #1454

  • [n] y/n | Does it introduce breaking changes?
  • [n] y/n | Is it dependant on the specific version of cargo-contract or pallet-contracts?
    Migrating the measurement and publish workflows to GitHub Actions

Description

Depends on #1977
Adds the measurement and publish-docs workflows

Checklist before requesting a review

  • [y] My code follows the style guidelines of this project
  • [n] I have added an entry to CHANGELOG.md
  • [y] I have commented my code, particularly in hard-to-understand areas
  • [n] I have added tests that prove my fix is effective or that my feature works
  • [y] Any dependent changes have been merged and published in downstream modules

@smiasojed smiasojed changed the title Migrating the measurement workflow to GitHub Actions Migrating the measurement and publish workflows to GitHub Actions Nov 7, 2023
@smiasojed smiasojed marked this pull request as ready for review November 7, 2023 08:28
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this stage I reckon we should just delete it from the gitlab runner already.

Then we should delete the contract sizes comment from this PR and we can prove it is working for sure.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test it correctly we need to merge #1977 first
We do not need to delete comment, just will be added another one. Now comments are submitted from 'github-actions[bot]' account

@use-ink use-ink deleted a comment from paritytech-cicd-pr Nov 8, 2023
@use-ink use-ink deleted a comment from codecov-commenter Nov 8, 2023
@use-ink use-ink deleted a comment from codecov-commenter Nov 9, 2023
@use-ink use-ink deleted a comment from codecov-commenter Nov 9, 2023
@use-ink use-ink deleted a comment from github-actions bot Nov 9, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

Merging #1971 (2025907) into master (d125d7e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1971      +/-   ##
==========================================
+ Coverage   53.31%   53.34%   +0.02%     
==========================================
  Files         219      219              
  Lines        6835     6835              
==========================================
+ Hits         3644     3646       +2     
+ Misses       3191     3189       -2     

see 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link

github-actions bot commented Nov 9, 2023

🦑 📈 ink! Example Contracts ‒ Changes Report 📉 🦑

These are the results when building the integration-tests/* contracts from this branch with cargo-contract and comparing them to ink! master:

Contract Upstream Size (kB) PR Size (kB) Diff (kB) Diff (%) Change
basic-contract-caller 2.967 2.967 0 0
basic-contract-caller/other-contract 1.337 1.337 0 0
call-builder-return-value 8.735 8.735 0 0
call-runtime 1.769 1.769 0 0
conditional-compilation 1.209 1.209 0 0
contract-storage 7.171 7.171 0 0
contract-terminate 1.092 1.092 0 0
contract-transfer 1.444 1.444 0 0
custom-allocator 7.428 7.428 0 0
dns 7.249 7.249 0 0
e2e-call-runtime 1.058 1.058 0 0
e2e-runtime-only-backend 1.635 1.635 0 0
erc1155 13.962 13.962 0 0
erc20 6.687 6.687 0 0
erc721 9.64 9.64 0 0
events 4.763 4.763 0 0
flipper 1.393 1.393 0 0
incrementer 1.221 1.221 0 0
lang-err-integration-tests/call-builder-delegate 2.317 2.317 0 0
lang-err-integration-tests/call-builder 4.847 4.847 0 0
lang-err-integration-tests/constructors-return-value 1.773 1.773 0 0
lang-err-integration-tests/contract-ref 4.328 4.328 0 0
lang-err-integration-tests/integration-flipper 1.571 1.571 0 0
mapping-integration-tests 7.685 7.685 0 0
mother 9.508 9.508 0 0
multi-contract-caller 5.924 5.924 0 0
multi-contract-caller/accumulator 1.095 1.095 0 0
multi-contract-caller/adder 1.669 1.669 0 0
multi-contract-caller/subber 1.689 1.689 0 0
multisig 21.471 21.471 0 0
payment-channel 5.501 5.501 0 0
sr25519-verification 0.865 0.865 0 0
static-buffer 1.405 1.405 0 0
trait-dyn-cross-contract-calls 2.466 2.466 0 0
trait-dyn-cross-contract-calls/contracts/incrementer 1.305 1.305 0 0
trait-erc20 7.063 7.063 0 0
trait-flipper 1.209 1.209 0 0
trait-incrementer 1.37 1.37 0 0
upgradeable-contracts/delegator 2.908 2.908 0 0
upgradeable-contracts/delegator/delegatee 1.369 1.369 0 0
upgradeable-contracts/set-code-hash 1.464 1.464 0 0
upgradeable-contracts/set-code-hash/updated-incrementer 1.443 1.443 0 0
wildcard-selector 2.622 2.622 0 0

Link to the run | Last update: Thu Nov 9 10:34:59 CET 2023

@smiasojed
Copy link
Collaborator Author

smiasojed commented Nov 9, 2023

Codecov Report

Merging #1971 (2025907) into master (d125d7e) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1971      +/-   ##
==========================================
+ Coverage   53.31%   53.34%   +0.02%     
==========================================
  Files         219      219              
  Lines        6835     6835              
==========================================
+ Hits         3644     3646       +2     
+ Misses       3191     3189       -2     

see 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@sergejparity could you please take a look into codecov job if it looks good for you?
I see that we have:
https://app.codecov.io/gh/paritytech-ci/ink/pulls
https://app.codecov.io/gh/paritytech/ink/pulls
could you please clarify what is the difference between them?

Copy link
Collaborator

@ascjones ascjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@sergejparity sergejparity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ascjones ascjones merged commit c7e1979 into master Nov 13, 2023
42 checks passed
@ascjones ascjones deleted the sm/github-measurement branch November 13, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants