Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge runtime / runtime-only #1968

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Merge runtime / runtime-only #1968

merged 5 commits into from
Nov 3, 2023

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Nov 2, 2023

Move runtime as an associated value of the variant RuntimeOnly.

Todo:

  • Update doc

@pgherveou
Copy link
Contributor Author

@pmikolajczyk41 does it make sense to have both fields rather than 1 variant with associated type?
feel free to close if this is completely stupid 🙃

@pgherveou pgherveou marked this pull request as ready for review November 2, 2023 16:18
@pgherveou
Copy link
Contributor Author

pgherveou commented Nov 2, 2023

@SkymanOne updated.
tldr the associated type force you to at least specify the backend like this to use the default runtime

 #[ink_e2e::test(backend(runtime_only()))]
// you need the () after runtime_only

specifying a custom one is done with

 #[ink_e2e::test(backend(runtime_only(runtime = ink_e2e::MinimalRuntime)))]

e2e tests run by default or I need to trigger them manually, to check nothing is broken?

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

Merging #1968 (ad73049) into master (02c4f0d) will decrease coverage by 0.03%.
Report is 17 commits behind head on master.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #1968      +/-   ##
==========================================
- Coverage   52.92%   52.90%   -0.03%     
==========================================
  Files         219      219              
  Lines        6781     6780       -1     
==========================================
- Hits         3589     3587       -2     
- Misses       3192     3193       +1     
Files Coverage Δ
crates/e2e/macro/src/config.rs 90.00% <100.00%> (-1.67%) ⬇️
crates/e2e/macro/src/codegen.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Member

@pmikolajczyk41 pmikolajczyk41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very good idea, thanks!

@pgherveou pgherveou merged commit 6fa4343 into master Nov 3, 2023
23 checks passed
@pgherveou pgherveou deleted the ink_backend_tweak branch November 3, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants