-
Notifications
You must be signed in to change notification settings - Fork 432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge runtime / runtime-only #1968
Conversation
@pmikolajczyk41 does it make sense to have both fields rather than 1 variant with associated type? |
0143bfd
to
830777c
Compare
@SkymanOne updated. #[ink_e2e::test(backend(runtime_only()))]
// you need the () after runtime_only specifying a custom one is done with #[ink_e2e::test(backend(runtime_only(runtime = ink_e2e::MinimalRuntime)))] e2e tests run by default or I need to trigger them manually, to check nothing is broken? |
Codecov Report
@@ Coverage Diff @@
## master #1968 +/- ##
==========================================
- Coverage 52.92% 52.90% -0.03%
==========================================
Files 219 219
Lines 6781 6780 -1
==========================================
- Hits 3589 3587 -2
- Misses 3192 3193 +1
... and 1 file with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very good idea, thanks!
Move runtime as an associated value of the variant RuntimeOnly.
Todo: