Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(progress-bar): make progress bar work for simple flow as well as branch flow #116

Merged
merged 1 commit into from
Oct 18, 2021
Merged

fix(progress-bar): make progress bar work for simple flow as well as branch flow #116

merged 1 commit into from
Oct 18, 2021

Conversation

dfurber
Copy link
Contributor

@dfurber dfurber commented Aug 4, 2021 •
edited
Loading

Story Reference

Story #85
This fixes an issue I found when I tried out the "simple flow" and noticed that the progress bar didn't move until the very end.

Summary

Looks like when you added branching, the progress bar got switched to counting branch questions. Yet branches remained optional for questions. That made the progress bar always think it was on the first step until it was on the last. The proposed change checks to see whether there are branches. If there are, then it uses the existing behavior. If not, then it counts up the number of questions.

Author Checklist

I have added/updated:

  • Tests
  • Documentation
  • Release notes (title of this PR)

Version Bump

  • Patch (bug fix - backwards compatible)
  • Minor (new functionality - backwards compatible)
  • Major (significant change - not backwards compatible)

froehlichcr
froehlichcr reviewed Oct 18, 2021
View reviewed changes
Copy link
Contributor

@froehlichcr froehlichcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done. Thanks!

@froehlichcr froehlichcr changed the title make progress bar work for simple flow as well as branch flow fix(progress-bar): make progress bar work for simple flow as well as branch flow Oct 18, 2021
@froehlichcr froehlichcr merged commit fa51c4a into usds:main Oct 18, 2021
github-actions bot pushed a commit that referenced this pull request Oct 18, 2021
@semantic-release-bot
release: 1.4.0 [skip ci] nn# [1.4.0](v1.3.6...v1.4.0) (2021-10-18)
ebb19a3 
### Bug Fixes

* **lint:** skips else for return ([#147](#147)) ([3218b81](3218b81))
* **progress-bar:** make progress bar work for simple flow as well as branch flow ([#116](#116)) ([fa51c4a](fa51c4a))

### Features

* **cookies:** enables persistent state ([#146](#146)) ([30bd966](30bd966))
@github-actions
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froehlichcr froehlichcr froehlichcr left review comments

@TomNUSDS TomNUSDS Awaiting requested review from TomNUSDS

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfurber @froehlichcr