Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint yaml files & add to pre-commit -- #161 #162

Open
wants to merge 32 commits into
base: main
Choose a base branch
from
Open

Conversation

jGaboardi
Copy link
Collaborator

lint yaml files & add to pre-commit -- #161

@jGaboardi
Copy link
Collaborator Author

jGaboardi commented Dec 27, 2024

While running yamllint directly1, all errors/warning are picked up as they should be. However, it seems that pre-commit itself is always skipping everything when the hook is run. This is true for both here before CI and locally.

There is documented support for this on both the yamllint docs and pre-commit docs, so I am probably missing something trivial that is causing this... but I am running up against a wall to figure out what.

cc @martinfleis

Footnotes

  1. e.g. $ yamllint -d "{extends: relaxed, ignore: .pixi/*, rules: {line-length: {max: 90}}}" .

@jGaboardi jGaboardi self-assigned this Dec 27, 2024
@jGaboardi jGaboardi added the housekeeping infrastructure, workflows, etc. label Dec 27, 2024
@jGaboardi
Copy link
Collaborator Author

An example local run through pre-commit that simply skips the step with "no files to check".

Screenshot 2024-12-27 at 5 01 18 PM

@martinfleis
Copy link
Contributor

Line 2 of pre commit config specifies to check only files within the neatnet folder. There are no YAML files in there.

@jGaboardi
Copy link
Collaborator Author

Line 2 of pre commit config specifies to check only files within the neatnet folder. There are no YAML files in there.

omg...

@jGaboardi
Copy link
Collaborator Author

confirmed now running and passing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping infrastructure, workflows, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants